Add ability to extend TestCall to create custom chained helpers
#1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHWelch
commented
Sep 19, 2024
Comment on lines
+664
to
+666
| $this->description = "extend: $name"; | ||
| $this->testCaseMethod->closure = fn (): null => null; |
There was a problem hiding this comment.
This is required because extend is being called non-statically. With this combination no errors are thrown and no output is included from a test()->extend(...) call.
I would need to add a different StaticallyExtendable or something like it to be able to use TestCall::extend(...) which is another possible API.
JHWelch
force-pushed
the
add-test-call-extension
branch
2 times, most recently
from
1f28941
to
86cf528
Compare
JHWelch
force-pushed
the
add-test-call-extension
branch
from
86cf528
to
9f77459
Compare
JHWelch
force-pushed
the
add-test-call-extension
branch
from
9f77459
to
3009567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Adds the ability to
->extend(...)TestCallin the same fashion that expectations are extendable.I had this idea after discussing on Pinkary and realize this was not currently a way Pest could be extended.
This opens up the framework for a whole new area of extensibility.
If this is something you want to add, I can PR the docs repo wherever makes sense.